This is an automated email from the ASF dual-hosted git repository.

tabish pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git


The following commit(s) were added to refs/heads/main by this push:
     new 8d5e75977e ARTEMIS-5358 log when core bridge fails to send a message
8d5e75977e is described below

commit 8d5e75977e406519cfe12caf99b903dd483f4ae6
Author: Justin Bertram <[email protected]>
AuthorDate: Wed Mar 19 12:00:02 2025 -0500

    ARTEMIS-5358 log when core bridge fails to send a message
    
    If the core bridge fails to send a message it does not provide any
    feedback at all. This commit fixes that problem by clearly logging
    details of the failure when it occurs.
---
 .../org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java  | 3 +++
 .../apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java   | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git 
a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java
 
b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java
index 727494fa2d..52767b92d9 100644
--- 
a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java
+++ 
b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java
@@ -1492,4 +1492,7 @@ public interface ActiveMQServerLogger {
 
    @LogMessage(id = 224142, value = "Unexpected result disconnecting consumer 
{} while closing session {}: {}", level = LogMessage.Level.WARN)
    void unexpectedResultDisconnectingConsumer(long consumerId, String 
sessionId, String exceptionMessage);
+
+   @LogMessage(id = 224143, value = "Bridge {} failed to send {}: {} {}", 
level = LogMessage.Level.WARN)
+   void bridgeFailedToSend(String bridgeName, String message, String 
exceptionName, String exceptionMessage);
 }
diff --git 
a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java
 
b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java
index ea372448f1..fd2eb06572 100644
--- 
a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java
+++ 
b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java
@@ -447,8 +447,8 @@ public class BridgeImpl implements Bridge, 
SessionFailureListener, SendAcknowled
 
    @Override
    public void sendFailed(Message message, Exception e) {
+      ActiveMQServerLogger.LOGGER.bridgeFailedToSend(configuration.getName(), 
message.toString(), e.getClass().getSimpleName(), e.getMessage());
       if (e instanceof ActiveMQAddressFullException) {
-         logger.warn(e.getMessage(), e);
          failed(e);
       }
    }


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to