This is an automated email from the ASF dual-hosted git repository.

andytaylor pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/activemq-artemis-console.git


The following commit(s) were added to refs/heads/main by this push:
     new 7438037  ARTEMIS-5450 - Fix issues with favicon
7438037 is described below

commit 743803743dc7b76590e619ffffcc54c251388d74
Author: GChuf <[email protected]>
AuthorDate: Wed Apr 30 13:02:07 2025 +0200

    ARTEMIS-5450 - Fix issues with favicon
    
    Fix 403 errors
    Add a proper .ico favicon containing images of resolutions 16x16, 24x24, 
32x32, 48x48, 64x64, 128x128 and 256x256 px
---
 .../artemis-extension/app/public/hawtconfig.json       |   3 +--
 .../artemis-extension/app/public/img/favicon.ico       | Bin 0 -> 119636 bytes
 .../artemis-extension/app/public/img/favicon.png       | Bin 37357 -> 0 bytes
 .../artemis-extension/app/public/index.html            |   2 +-
 .../artemis-extension/app/webpack.config.cjs           |   2 +-
 5 files changed, 3 insertions(+), 4 deletions(-)

diff --git 
a/artemis-console-extension/artemis-extension/app/public/hawtconfig.json 
b/artemis-console-extension/artemis-extension/app/public/hawtconfig.json
index 94025a2..aac7d5b 100644
--- a/artemis-console-extension/artemis-extension/app/public/hawtconfig.json
+++ b/artemis-console-extension/artemis-extension/app/public/hawtconfig.json
@@ -4,8 +4,7 @@
     "showAppName": false,
     "appLogoUrl": "img/activemq.png",
     "companyLogoUrl": "img/activemq.png",
-    "css": "css/activemq.css",
-    "favicon": "img/favicon.png"
+    "css": "css/activemq.css"
   },
   "login": {
     "description": "Login page for Artemis Console.",
diff --git 
a/artemis-console-extension/artemis-extension/app/public/img/favicon.ico 
b/artemis-console-extension/artemis-extension/app/public/img/favicon.ico
new file mode 100644
index 0000000..0c3ac82
Binary files /dev/null and 
b/artemis-console-extension/artemis-extension/app/public/img/favicon.ico differ
diff --git 
a/artemis-console-extension/artemis-extension/app/public/img/favicon.png 
b/artemis-console-extension/artemis-extension/app/public/img/favicon.png
deleted file mode 100644
index c2b43f5..0000000
Binary files 
a/artemis-console-extension/artemis-extension/app/public/img/favicon.png and 
/dev/null differ
diff --git a/artemis-console-extension/artemis-extension/app/public/index.html 
b/artemis-console-extension/artemis-extension/app/public/index.html
index c0b73ac..e278971 100644
--- a/artemis-console-extension/artemis-extension/app/public/index.html
+++ b/artemis-console-extension/artemis-extension/app/public/index.html
@@ -24,7 +24,7 @@
 
     <!-- Hawtio branding styles and favicon placeholders -->
     <link id="branding" rel="stylesheet" type="text/css" href="" />
-    <link id="favicon" rel="icon" type="image/png" href="" />
+    <link id="favicon" rel="icon" type="image/x-icon" href="img/favicon.ico" />
 
     <title>Artemis Console</title>
   </head>
diff --git a/artemis-console-extension/artemis-extension/app/webpack.config.cjs 
b/artemis-console-extension/artemis-extension/app/webpack.config.cjs
index d86cdbc..36dbfb4 100644
--- a/artemis-console-extension/artemis-extension/app/webpack.config.cjs
+++ b/artemis-console-extension/artemis-extension/app/webpack.config.cjs
@@ -101,7 +101,7 @@ module.exports = (webpackEnv, args) => {
             context: 'public/',
             globOptions: {
               gitignore: true,
-              ignore: ['**/index.html', '**/favicon.ico'],
+              ignore: ['**/index.html'],
             },
           },
         ],


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to