(activemq) branch main updated: AMQ-9718 Removed collections which are never queried (#1444)

[jbonofre]

This is an automated email from the ASF dual-hosted git repository.

jbonofre pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/activemq.git


The following commit(s) were added to refs/heads/main by this push:
     new 51553ddc5f AMQ-9718 Removed collections which are never queried (#1444)
51553ddc5f is described below

commit 51553ddc5f4fac3cd8d89dc5cf485d5d527d60d1
Author: Dmitry Kryukov <d...@users.noreply.github.com>
AuthorDate: Mon Sep 29 06:58:42 2025 +0300

    AMQ-9718 Removed collections which are never queried (#1444)
---
 .../src/test/java/org/apache/activemq/store/PListTestSupport.java  | 2 --
 .../java/org/apache/activemq/console/command/BrowseCommand.java    | 7 -------
 .../java/org/apache/activemq/console/command/PurgeCommand.java     | 7 -------
 3 files changed, 16 deletions(-)

diff --git 
a/activemq-broker/src/test/java/org/apache/activemq/store/PListTestSupport.java 
b/activemq-broker/src/test/java/org/apache/activemq/store/PListTestSupport.java
index b40a6692cd..5e6d0c58e4 100644
--- 
a/activemq-broker/src/test/java/org/apache/activemq/store/PListTestSupport.java
+++ 
b/activemq-broker/src/test/java/org/apache/activemq/store/PListTestSupport.java
@@ -128,11 +128,9 @@ public abstract class PListTestSupport {
     }
 
     protected void doTestRemove(final int COUNT) throws IOException {
-        Map<String, ByteSequence> map = new LinkedHashMap<String, 
ByteSequence>();
         for (int i = 0; i < COUNT; i++) {
             String test = new String("test" + i);
             ByteSequence bs = new ByteSequence(test.getBytes());
-            map.put(test, bs);
             plist.addLast(test, bs);
         }
         assertEquals(plist.size(), COUNT);
diff --git 
a/activemq-console/src/main/java/org/apache/activemq/console/command/BrowseCommand.java
 
b/activemq-console/src/main/java/org/apache/activemq/console/command/BrowseCommand.java
index 68b6ff3bf1..7bf61442fd 100644
--- 
a/activemq-console/src/main/java/org/apache/activemq/console/command/BrowseCommand.java
+++ 
b/activemq-console/src/main/java/org/apache/activemq/console/command/BrowseCommand.java
@@ -75,7 +75,6 @@ public class BrowseCommand extends AbstractJmxCommand {
     };
 
     private final List<String> queryAddObjects = new ArrayList<String>(10);
-    private final List<String> querySubObjects = new ArrayList<String>(10);
     private final Set<String> groupViews = new HashSet<String>(10);
     private final Set queryViews = new HashSet(10);
 
@@ -144,12 +143,6 @@ public class BrowseCommand extends AbstractJmxCommand {
             // option
             if (tokens.isEmpty() || ((String)tokens.get(0)).startsWith("-")) {
                 context.printException(new IllegalArgumentException("Message 
selector not specified"));
-                return;
-            }
-
-            StringTokenizer queryTokens = new 
StringTokenizer((String)tokens.remove(0), COMMAND_OPTION_DELIMETER);
-            while (queryTokens.hasMoreTokens()) {
-                querySubObjects.add(queryTokens.nextToken());
             }
 
         } else if (token.startsWith("--view")) {
diff --git 
a/activemq-console/src/main/java/org/apache/activemq/console/command/PurgeCommand.java
 
b/activemq-console/src/main/java/org/apache/activemq/console/command/PurgeCommand.java
index 4974925f4f..c312c735e7 100644
--- 
a/activemq-console/src/main/java/org/apache/activemq/console/command/PurgeCommand.java
+++ 
b/activemq-console/src/main/java/org/apache/activemq/console/command/PurgeCommand.java
@@ -60,7 +60,6 @@ public class PurgeCommand extends AbstractJmxCommand {
     };
 
     private final List<String> queryAddObjects = new ArrayList<String>(10);
-    private final List<String> querySubObjects = new ArrayList<String>(10);
     private boolean resetStatistics;
 
     @Override
@@ -175,12 +174,6 @@ public class PurgeCommand extends AbstractJmxCommand {
             // option
             if (tokens.isEmpty() || tokens.get(0).startsWith("-")) {
                 context.printException(new IllegalArgumentException("Message 
selector not specified"));
-                return;
-            }
-
-            StringTokenizer queryTokens = new 
StringTokenizer(tokens.remove(0), COMMAND_OPTION_DELIMETER);
-            while (queryTokens.hasMoreTokens()) {
-                querySubObjects.add(queryTokens.nextToken());
             }
         } else if (token.startsWith("--reset")) {
             resetStatistics = true;


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@activemq.apache.org
For additional commands, e-mail: commits-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact