sorrell opened a new pull request, #205:
URL: https://github.com/apache/incubator-age/pull/205
This PR would address #204 where Docker Hub is building based on tag pushed,
but the Dockerfile clones the head of master. The changes include:
## Changes
- Removing unnecessary dependencies
- Changing `git clone` to COPY contents of Dockerfile's working directory
(root of the repo) into the container for the build
## Testing
- Tested using
* This Github repository https://github.com/VouchLLC/incubator-age
* This Docker Hub repo https://hub.docker.com/r/sorrell/test-age-change
- Tests consisted of
* Creating annotated tag (1.0.1) on commit containing changes and pushing
to trigger build. Image was verified to be using 1.0.1 branch.
* Creating annotated tag (1.0.2) on commit containing changes and pushing
to trigger build. Image was verified to be using 1.0.2 branch.
* Creating annotated tag (0.9.0) on commit NOT containing changes and
pushing to trigger build. Image was verified to be using master branch,
matching functionality we are trying to change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
