uhayat commented on code in PR #692: URL: https://github.com/apache/age/pull/692#discussion_r1112037162
########## debian/control.in: ########## @@ -0,0 +1,51 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at + +# http://www.apache.org/licenses/LICENSE-2.0 + +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + + +Source: age +Section: database +Priority: optional +Maintainer: Debian PostgreSQL Maintainers <[email protected]> +Uploaders: + Sarthak Jaiswal <[email protected]>, + Ahmar Zaidi <[email protected]>, +Build-Depends: + debhelper-compat (= 13), + postgresql-11 | postgresql-12, + build-essential, + libreadline-dev, + zlib1g-dev, + flex, + bison, +Standards-Version: 4.5.1 +Rules-Requires-Root: no +Homepage: https://age.apache.org +Vcs-Browser: https://salsa.debian.org/postgresql/age +Vcs-Git: https://salsa.debian.org/postgresql/age.git + Review Comment: L#37,38 need to be removed ########## debian/copyright: ########## @@ -0,0 +1,33 @@ +Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ +Upstream-Name: age +Upstream-Contact: Apache Age <[email protected]> +Source: https://github.com/apache/age + +Files: * +Copyright: <years> <put author's name and email here> + <years> <likewise for another author> + + +Files: debian/* +Copyright: 2023 Ahmar Zaidi <ahmarzaidi07@gmail> + 2023 Sarthak Jaiswal <[email protected]> + Review Comment: These need to be removed from L#1 to L#14 ########## debian/control.in: ########## @@ -0,0 +1,51 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at + +# http://www.apache.org/licenses/LICENSE-2.0 + +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + + +Source: age +Section: database +Priority: optional +Maintainer: Debian PostgreSQL Maintainers <[email protected]> +Uploaders: + Sarthak Jaiswal <[email protected]>, + Ahmar Zaidi <[email protected]>, Review Comment: From L#22 to L25 use Apache AGE team emails ########## debian/changelog: ########## @@ -0,0 +1,6 @@ +age (1.1.1) UNRELEASED; urgency=medium + + * Initial release + + -- Ahmar Zaidi <[email protected]> Tue, 07 Feb 2023 15:34:58 +0530 + -- Sarthak Jaiswal <[email protected]> Tue, 07 Feb 2023 15:34:59 +0530 Review Comment: Again use Apache AGE user, and also add only one author ########## debian/control.in: ########## @@ -0,0 +1,51 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at + +# http://www.apache.org/licenses/LICENSE-2.0 + +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + + +Source: age +Section: database +Priority: optional +Maintainer: Debian PostgreSQL Maintainers <[email protected]> +Uploaders: + Sarthak Jaiswal <[email protected]>, + Ahmar Zaidi <[email protected]>, +Build-Depends: + debhelper-compat (= 13), + postgresql-11 | postgresql-12, Review Comment: Only target PG12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
