uhayat commented on code in PR #691: URL: https://github.com/apache/age/pull/691#discussion_r1112503750
########## debian/rules: ########## @@ -0,0 +1,23 @@ +#!/usr/bin/make -f + +%: + dh $@ + +override_dh_installdocs: + dh_installdocs --all README.* + +# classic `pg_buildext` interface: +#include /usr/share/postgresql-common/pgxs_debian_control.mk +# +#override_dh_auto_build: +# +pg_buildext build build-%v +# +#override_dh_auto_test: +# # nothing to do here, see debian/tests/* instead +# +#override_dh_auto_install: +# +pg_buildext install build-%v postgresql-%v-age +# +#override_dh_auto_clean: +# +pg_buildext clean build-%v +# Review Comment: Remove the dead code L#8 till L#23 ########## debian/gitlab-ci.yml: ########## @@ -0,0 +1 @@ +include: https://salsa.debian.org/postgresql/postgresql-common/raw/master/gitlab/gitlab-ci.yml Review Comment: No need for this file and its incorrect ########## debian/control: ########## @@ -0,0 +1,51 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at + +# http://www.apache.org/licenses/LICENSE-2.0 + +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + + +Source: age +Section: database +Priority: optional +Maintainer: Debian PostgreSQL Maintainers <[email protected]> +Uploaders: + Sarthak Jaiswal <[email protected]>, + Ahmar Zaidi <[email protected]>, +Build-Depends: + debhelper-compat (= 13), + postgresql-11 | postgresql-12, + build-essential, + libreadline-dev, + zlib1g-dev, + flex, + bison, +Standards-Version: 4.5.1 +Rules-Requires-Root: no +Homepage: https://age.apache.org +Vcs-Browser: https://salsa.debian.org/postgresql/age +Vcs-Git: https://salsa.debian.org/postgresql/age.git Review Comment: L#37,38 not correct and should removed or fixed ########## debian/control: ########## @@ -0,0 +1,51 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at + +# http://www.apache.org/licenses/LICENSE-2.0 + +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + + +Source: age +Section: database +Priority: optional +Maintainer: Debian PostgreSQL Maintainers <[email protected]> +Uploaders: + Sarthak Jaiswal <[email protected]>, + Ahmar Zaidi <[email protected]>, +Build-Depends: + debhelper-compat (= 13), + postgresql-11 | postgresql-12, Review Comment: Target only PG12 ########## debian/control: ########## @@ -0,0 +1,51 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at + +# http://www.apache.org/licenses/LICENSE-2.0 + +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + + +Source: age +Section: database +Priority: optional +Maintainer: Debian PostgreSQL Maintainers <[email protected]> +Uploaders: + Sarthak Jaiswal <[email protected]>, + Ahmar Zaidi <[email protected]>, Review Comment: Use AGE maintainer email address from L#22 till L#25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
