rrrokhtar commented on PR #807: URL: https://github.com/apache/age/pull/807#issuecomment-1507720576
**Thanks for your comment** @jrgemignani Here are the answers to your questions 1. It is mentioned in the project that I am assigned to, so that creating it is not my suggestion at all but it is may be good to be added because you can not use pg_catalog.factorial function inside the cypher query, and if it is not good to have why do you think PostgreSQL has that https://www.postgresql.org/docs/11/functions-math.html 2. The variable types are following PostgreSQL and the similar mathematical functions on the same file like ag_sqrt. 3. There is no regression are added to the mathematical functions at all (i.e. age_sqrt) so I didn't write for it as well, if you like having tests for that I can do that no problem. Let me know which parts need to be fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
