jrgemignani commented on code in PR #889:
URL: https://github.com/apache/age/pull/889#discussion_r1183994700
##########
src/backend/parser/cypher_expr.c:
##########
@@ -152,12 +152,15 @@ static Node
*transform_cypher_expr_recurse(cypher_parsestate *cpstate,
case T_NullTest:
{
NullTest *n = (NullTest *)expr;
+ NullTest *tranformed_expr = makeNode(NullTest);
Review Comment:
Is there a particular reason for creating a new node as opposed to using the
passed node?
##########
src/backend/parser/cypher_expr.c:
##########
@@ -152,12 +152,15 @@ static Node
*transform_cypher_expr_recurse(cypher_parsestate *cpstate,
case T_NullTest:
{
NullTest *n = (NullTest *)expr;
+ NullTest *tranformed_expr = makeNode(NullTest);
Review Comment:
Actually, what about using the transformed node and just checking to see if
it was already transformed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
