jrgemignani commented on PR #895: URL: https://github.com/apache/age/pull/895#issuecomment-1542637549
@mohayu22 For future reference, your commit description block should be more concise - ``` commit a43002ae39132781c535031d426d04bc5464851e Author: mohayu22 <[email protected]> Date: Wed May 10 23:25:54 2023 +0500 Added string to pg_float8 typecasting (#895) * Added case for AGTV_STRING -Made changes to agtype_to_float8 -Modified if condition to check for AGTV_STRING -Added code for typecasting string to pg_float8 * Added and modified regression tests -Modified a test to return value instead of failing -Added new test to check string to pg_flaot8 typecasting * Added braces around code blocks Added braces {} around code blocks to keep up with standards. ``` Could be more like - ``` commit a43002ae39132781c535031d426d04bc5464851e Author: mohayu22 <[email protected]> Date: Wed May 10 23:25:54 2023 +0500 Added string to pg_float8 typecasting (#895) * Added case for AGTV_STRING -Made changes to agtype_to_float8 -Modified if condition to check for AGTV_STRING -Added code for typecasting string to pg_float8 * Added and modified regression tests ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
