Mghrabi commented on PR #937: URL: https://github.com/apache/age/pull/937#issuecomment-1555286369
Reason for making the PR: I went through an issue while trying to connect to a database and it failed for some reason (using a jupyter notebook), the cell that runs the connection request was running forever and without yielding any output as the `connect_timeout` is not set. By adding the `connect_timeout` long-time failed connections quit * Note: (FROM MY UNDERSTANDING) I think adding `timeout` is a good practice, especially for local connections which shouldn't take a long time to connect, that's why I made this PR anyway as it targets **samples** and **test** files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
