jsoref commented on code in PR #985:
URL: https://github.com/apache/age/pull/985#discussion_r1227494933
##########
CONTRIBUTING.md:
##########
@@ -20,7 +20,7 @@ We strongly recommend you to subscribe the mailing lists,
join the Apache AGE Di
## Pull Requests
-Changes to AGE source code are proposed, reviewed, and committed via Github
pull requests (described in Code Convention). Pull requests are a great way to
get your ideas into this repository. Anyone can view and comment on active
changes here. Reviewing others' changes are a good way to learn how the change
process works and gain exposure to activity in various parts of the code. You
can help by reviewing the changes, asking questions, or pointing out issues as
simple as typos.
+Changes to AGE source code are proposed, reviewed, and committed via GitHub
pull requests (described in Code Convention). Pull requests are a great way to
get your ideas into this repository. Anyone can view and comment on active
changes here. Reviewing others' changes are a good way to learn how the change
process works and gain exposure to activity in various parts of the code. You
can help by reviewing the changes, asking questions, or pointing out issues as
simple as typos.
Review Comment:
brand
##########
src/backend/executor/cypher_create.c:
##########
@@ -283,7 +283,7 @@ static void end_cypher_create(CustomScanState *node)
static void rescan_cypher_create(CustomScanState *node)
{
ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
- errmsg("cypher create clause cannot be rescaned"),
+ errmsg("cypher create clause cannot be rescanned"),
Review Comment:
api change?
##########
README.md:
##########
@@ -128,7 +128,7 @@ sudo apt-get install build-essential libreadline-dev
zlib1g-dev flex bison
Apache AGE is intended to be simple to install and run. It can be installed
with Docker and other traditional ways.
<h4><a><img width="20" src="/img/pg.svg"></a>
- Install PosgtreSQL
+ Install PostgreSQL
Review Comment:
brand
##########
drivers/golang/install.sh:
##########
@@ -104,7 +104,7 @@ if ! command -v go >/dev/null 2>&1 || { [ $(go version |
grep -o -E '[0-9]+\.[0-
sudo open -w golang.pkg
elif [[ "$os" == "Linux" ]]; then
- mdkir -p ~/tmp/go1.20.2
+ mkdir -p ~/tmp/go1.20.2
Review Comment:
build failure
##########
src/backend/parser/cypher_expr.c:
##########
@@ -153,15 +153,15 @@ static Node
*transform_cypher_expr_recurse(cypher_parsestate *cpstate,
case T_NullTest:
{
NullTest *n = (NullTest *)expr;
- NullTest *tranformed_expr = makeNode(NullTest);
+ NullTest *transformed_expr = makeNode(NullTest);
- tranformed_expr->arg = (Expr *)transform_cypher_expr_recurse(cpstate,
+ transformed_expr->arg = (Expr *)transform_cypher_expr_recurse(cpstate,
(Node *)n->arg);
Review Comment:
I'n not sure about the whitespace here, but it doesn't seem to be
particularly aligned, so I'm not touching it.
##########
src/backend/utils/adt/age_global_graph.c:
##########
@@ -41,7 +41,7 @@
/* internal data structures implementation */
-/* vertex entry for the vertex_hastable */
+/* vertex entry for the vertex_hashtable */
Review Comment:
?
##########
regress/expected/expr.out:
##########
@@ -1441,9 +1441,9 @@ RETURN ''::int
$$) AS r(result agtype);
ERROR: invalid input syntax for integer: ""
SELECT * FROM cypher('expr', $$
-RETURN 'falze'::int
+RETURN 'false_'::int
Review Comment:
I'm hoping this is an acceptable change. While `falze` != `false`, `false_`
!= `false` too, and it has the benefit of not being flagged by spell checking
tools.
I'm happy to drop this change or any other change.
##########
regress/expected/index.out:
##########
@@ -254,7 +254,7 @@ SELECT * FROM cypher('cypher_index', $$
(us)<-[:has_city]-(:City {city_id: 3, name:"Los Angeles", west_coast:
true, country_code:"US"}),
(us)<-[:has_city]-(:City {city_id: 4, name:"Seattle", west_coast:
true, country_code:"US"}),
(ca)<-[:has_city]-(:City {city_id: 5, name:"Vancouver", west_coast:
true, country_code:"CA"}),
- (ca)<-[:has_city]-(:City {city_id: 6, name:"Toroto", west_coast:
false, country_code:"CA"}),
+ (ca)<-[:has_city]-(:City {city_id: 6, name:"Toronto", west_coast:
false, country_code:"CA"}),
Review Comment:
I live here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
