CapnSpek commented on PR #994: URL: https://github.com/apache/age/pull/994#issuecomment-1602749359
The function `get_type_sort_priority` is not used anywhere other than the function `compare_agtype_containers_orderability` which is the function that decides between 2 given agtypes (of the same type or different type) which one should be prioritized above other. The function `get_type_sort_priority` is only used when deciding the orderability between different agtypes. All other cases (of same agtypes) are handled with the function, or by other function `compare_agtype_scalar_values`. I changed the `get_type_sort_priority` function to the suggested priority, reinstalled AGE, and ran the test cases. All the test cases have been passed. It also solves all the problems that were given in issue #870 . I think it is a good solution. Should I proceed to writing new regression tests? @rafsun42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
