dehowef commented on code in PR #1012: URL: https://github.com/apache/age/pull/1012#discussion_r1253711285
########## src/backend/executor/cypher_create.c: ########## Review Comment: Line 109 introduced a typo. Aquire should be acquire. ########## src/backend/executor/cypher_merge.c: ########## Review Comment: Line 120, same correction as mentioned above -- aquire-->acquire ########## src/backend/nodes/cypher_readfuncs.c: ########## Review Comment: I think John mentioned this too, but I will add my concern. Should there be a consistency in the READ_FIELD function for oid? Right now there are two changed instances of READ_OID_FIELD --> READ_INT_FIELD and one of READ_OID_FIELD to READ_UINT_FIELD. ########## src/include/parser/cypher_kwlist.h: ########## Review Comment: Lack of EOL in this file. Maybe needs one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
