jrgemignani commented on code in PR #1015:
URL: https://github.com/apache/age/pull/1015#discussion_r1254748784
##########
src/backend/utils/adt/agtype.c:
##########
@@ -151,25 +159,25 @@ static bool is_array_path(agtype_value *agtv);
/* graph entity retrieval */
static Datum get_vertex(const char *graph, const char *vertex_label,
int64 graphid);
-static char *get_label_name(const char *graph_name, int64 graph_id);
+static char *get_label_name(const char *graph_name, int64 label_id);
Review Comment:
I think that, overall, we have an issue with the name `graphid ` as a type
due to names of fields and variables like `graph_id` or `graph_oid`.
Additionally, `graphid ` is just an `int64`. So, I don't even know if we need
to have a type for it and then a field named like it. Still, I'm not sure if we
should attempt to fix this in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
