MuhammadTahaNaveed commented on code in PR #1081:
URL: https://github.com/apache/age/pull/1081#discussion_r1272650666
##########
src/backend/parser/cypher_clause.c:
##########
@@ -4356,7 +4358,7 @@ static Node *make_qual(cypher_parsestate *cpstate,
args = list_make1(entity->expr);
- node = (Node *)makeFuncCall(qualified_name, args, -1);
+ node = (Node *)makeFuncCall(qualified_name, args,
COERCE_EXPLICIT_CALL, -1);
Review Comment:
[formatting] exceeds 80
##########
src/backend/parser/cypher_clause.c:
##########
@@ -3167,7 +3169,7 @@ static List
*make_join_condition_for_edge(cypher_parsestate *cpstate,
args = list_make3(left_id, right_id, entity->expr);
// add to quals
- quals = lappend(quals, makeFuncCall(qualified_func_name, args,
-1));
+ quals = lappend(quals, makeFuncCall(qualified_func_name, args,
COERCE_EXPLICIT_CALL, -1));
Review Comment:
[formatting] exceeds 80
##########
src/backend/executor/cypher_utils.c:
##########
@@ -254,7 +254,7 @@ HeapTuple insert_entity_tuple_cid(ResultRelInfo
*resultRelInfo,
// Insert index entries for the tuple
if (resultRelInfo->ri_NumIndices > 0)
{
- ExecInsertIndexTuples(elemTupleSlot, estate, false, NULL, NIL);
+ ExecInsertIndexTuples(resultRelInfo, elemTupleSlot, estate, false,
false, NULL, NIL);
Review Comment:
[formatting] exceeds 80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
