Zainab-Saad commented on PR #1160: URL: https://github.com/apache/age/pull/1160#issuecomment-1684690823
@rafsun42 1. `agtype_value_to_agtype` is used to initialize the iterator 2. This is what I thought at first to remove the Assertion, but keeping this assertion makes more sense to me because if the value is an object it should not be pushed right away as we might be missing other checks. For example, the assertions for WAGT_KEY, WAGT_ELEM etc. So any non-scalar should be iterated when making an `agtype_value`. The approach I have used here for copying the properties is the same used for appending new properties into the `parsed_agtype_value` and the later one did not produce any bug for non-scalar values because it treats non-scalar values as `AGTV_BINARY` which in `push_agtype_value` is not directly passed to `push_agtype_value_scalar` to be pushed into agtype_value rather is iterated through and sent to `push_agtype_value_scalar` for pushing to agtype_value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
