jrgemignani commented on code in PR #1252: URL: https://github.com/apache/age/pull/1252#discussion_r1342936676
########## src/include/utils/agtype_ext.h: ########## @@ -24,6 +24,10 @@ #include "utils/agtype.h" +/* define the type and size of the agt_header */ +#define AGT_HEADER_TYPE uint32 Review Comment: Are we sure that we want to expose the implementation to others? Not saying this is wrong, just asking the question. ########## src/include/utils/agtype_raw.h: ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/* + * This module provides functions for directly building agtype + * without using agtype_value. + */ + +#ifndef AG_AGTYPE_RAW_H +#define AG_AGTYPE_RAw_H + +#include "postgres.h" +#include "utils/agtype.h" +#include "utils/agtype_ext.h" + +/* + * Used for building an agtype container. + */ +typedef struct agtype_build_state Review Comment: Are we sure that we want to expose the implementation to others? Not saying this is wrong, just asking the question. ########## src/backend/utils/adt/agtype_ext.c: ########## @@ -21,10 +21,6 @@ #include "utils/agtype.h" #include "utils/graphid.h" -/* define the type and size of the agt_header */ -#define AGT_HEADER_TYPE uint32 Review Comment: Are we sure that we want to expose the implementation to others? Not saying this is wrong, just asking the question. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
