jrgemignani opened a new pull request, #1288:
URL: https://github.com/apache/age/pull/1288
Fixed issue 945 where count(*) would have incorrect return values.
NOTE -
We need to re-evaluate if we want to use output_node or not. If output_node
is set to false, then it basically short circuits match for instances where a
variable isn't specified -
MATCH () RETURN 0;
MATCH () MATCH () RETURN 0;
While, on the surface, this appears to be a good way to improve execution
time of commands that won't do anything, it also causes chained commands to not
work correctly. This is because a match without a variable will still feed its
tuples to the next stage(s) even though they won't necessarily be sent to the
output. For example, with count(*) -
MATCH () RETURN count(*);
MATCH () MATCH RETURN count(*);
With output_node set to false, it won't send the tuples. We will likely need
to remove all of the output_node logic. However, this needs to be reviewed. For
now, we just set it to true and update the output of the regression tests.
Updated regression tests to accomodate the change. Added new regression
tests to cover overlooked cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
