jrgemignani commented on code in PR #1311:
URL: https://github.com/apache/age/pull/1311#discussion_r1374975397
##########
src/backend/parser/cypher_gram.y:
##########
@@ -2274,25 +2274,180 @@ static Node *make_function_expr(List *func_name, List
*exprs, int location)
* could be many.
*/
if (pg_strcasecmp(name, "count") == 0)
+ {
+ funcname = SystemFuncName("count");
+
+ /* build the function call */
+ fnode = makeFuncCall(funcname, exprs, COERCE_SQL_SYNTAX, location);
+
+ /* build the cast to wrap the function call to return agtype. */
+ fnode = wrap_pg_funccall_to_agtype((Node *)fnode, "integer",
location);
+
+ return (Node *)fnode;
+ }
+ else
+ {
+ /*
+ * We don't qualify AGE functions here. This is done in the
+ * transform layer and allows us to know which functions are ours.
+ */
+ funcname = func_name;
+
+ /* build the function call */
+ fnode = makeFuncCall(funcname, exprs, COERCE_SQL_SYNTAX, location);
+ }
+ }
+ /* all other functions are passed as is */
+ else
Review Comment:
Missing {}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
