MuhammadTahaNaveed commented on code in PR #1451:
URL: https://github.com/apache/age/pull/1451#discussion_r1427094149
##########
src/backend/parser/cypher_parse_agg.c:
##########
@@ -236,7 +236,7 @@ void parse_check_aggregates(ParseState *pstate, Query *qry)
finalize_grouping_exprs(clause, pstate, qry, groupClauses, root,
have_non_var_grouping);
if (hasJoinRTEs)
- clause = flatten_join_alias_vars((Query*)root, clause);
+ clause = flatten_join_alias_vars(root, qry, clause);
Review Comment:
missing curly braces
##########
src/backend/parser/cypher_parse_agg.c:
##########
@@ -562,7 +562,9 @@ static bool finalize_grouping_exprs_walker(Node *node,
Index ref = 0;
if (context->root)
- expr = flatten_join_alias_vars((Query*)context->root,
expr);
+ expr = flatten_join_alias_vars(context->root,
Review Comment:
missing curly braces
##########
src/backend/parser/cypher_parse_agg.c:
##########
@@ -245,7 +245,7 @@ void parse_check_aggregates(ParseState *pstate, Query *qry)
finalize_grouping_exprs(clause, pstate, qry, groupClauses, root,
have_non_var_grouping);
if (hasJoinRTEs)
- clause = flatten_join_alias_vars((Query*)root, clause);
+ clause = flatten_join_alias_vars(root, qry, clause);
Review Comment:
missing curly braces
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
