dehowef commented on code in PR #1610:
URL: https://github.com/apache/age/pull/1610#discussion_r1492153265
##########
src/include/parser/cypher_clause.h:
##########
@@ -39,4 +39,13 @@ Query *cypher_parse_sub_analyze(Node *parseTree,
CommonTableExpr *parentCTE,
bool locked_from_parent,
bool resolve_unknowns);
+
+typedef Query *(*transform_method)(cypher_parsestate *cpstate,
Review Comment:
Not major, but if you are moving this Query typedef to the header, you could
removing the redundant typedef in the .c file
##########
src/include/parser/cypher_clause.h:
##########
@@ -39,4 +39,13 @@ Query *cypher_parse_sub_analyze(Node *parseTree,
CommonTableExpr *parentCTE,
bool locked_from_parent,
bool resolve_unknowns);
+
+typedef Query *(*transform_method)(cypher_parsestate *cpstate,
+ cypher_clause *clause);
+
+ParseNamespaceItem *transform_cypher_clause_as_subquery(cypher_parsestate
*cpstate,
Review Comment:
Same thing goes for this transform_cypher_clause_as_subquery definition as
mentioned for the Query typedef. Any particular reason why the declaration was
left in the .c file? Readability?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
