theory commented on PR #1711: URL: https://github.com/apache/age/pull/1711#issuecomment-2064717091
Yes, I tested it with the exception of actually releasing it. See [this build](/theory/age/actions/runs/8395514381/job/22994946387). The changes to the Makefile are no strictly speaking required; I thought it useful to demonstrate how to use it to set the version in one place. pgrx projects often read the version from a `Cargo.toml` file, but many PGXS-based projects use the `META.json` file. The `dist` target is not required, but handy to manually check that that the PGXN zip file is generated properly. We could probably remove it all if you'd like; the [`pgxn-bundle`](https://github.com/pgxn/docker-pgxn-tools/blob/main/bin/pgxn-bundle) command used in the release workflow does pretty much the same thing, depending on the `META.json` file to read the version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
