jrgemignani commented on code in PR #2258:
URL: https://github.com/apache/age/pull/2258#discussion_r2585707138
##########
src/backend/utils/adt/agtype.c:
##########
@@ -5708,8 +5716,6 @@ Datum age_startnode(PG_FUNCTION_ARGS)
result = get_vertex(graph_name, label_name, start_id);
- free(label_name);
Review Comment:
Why remove this?
##########
src/backend/utils/adt/agtype.c:
##########
@@ -181,6 +181,14 @@ static agtype_value
*agtype_build_map_as_agtype_value(FunctionCallInfo fcinfo);
agtype_value *agtype_composite_to_agtype_value_binary(agtype *a);
static agtype_value *tostring_helper(Datum arg, Oid type, char *msghdr);
+
+void *repalloc_check(void *ptr, size_t len)
+{
+ if (ptr)
Review Comment:
Our current standard for all new code (for the past few years) is to always
use {} for all control blocks (if, for, while, etc.)
##########
src/backend/utils/adt/agtype.c:
##########
@@ -5773,8 +5779,6 @@ Datum age_endnode(PG_FUNCTION_ARGS)
result = get_vertex(graph_name, label_name, end_id);
- free(label_name);
Review Comment:
Why remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
