MuhammadTahaNaveed commented on PR #2303: URL: https://github.com/apache/age/pull/2303#issuecomment-3744266669
@jrgemignani > 1. There aren't any additions to the `age--1.6.0--y.y.y.sql` file which is needed for upgrading. I won't be able to test actual performance without this file. Updated `age--1.6.0--y.y.y.sql` > 2. These changes to the types will generally make it difficult to upgrade. The changed functions (_label_name, _agtype_build_vertex, _agtype_build_edge) are intended for internal use only. They are invoked by the parser/executor and are not meant to be called directly by users. The upgrade script in age--1.6.0--y.y.y.sql manages the transition by dropping the old function signatures and creating the new ones. No data migration is required, as the underlying table structure remains unchanged. From a user perspective, existing queries that return agtype continue to work without any changes. The composite types are introduced to improve internal query transformation and serve as an additional output option, rather than a breaking change. > 3. The composite vertex and edge types are an interesting touch, but, it doesn't appear that you removed how the vertices and edges are represented in agtype. If this is intended, won't this increase the space taken by these objects? The composite types don’t increase storage, as they are only a query-time representation. The underlying tables continue to store the same data as before. The agtype representation is still required for paths (which are agtype arrays of vertices/edges), for storing entities in agtype containers, and for compatibility with existing agtype operators. When agtype is needed, the implicit casts(backed by functions vertex_to_agtype and edge_to_agtype) handle the conversion. > Ambiguous operator added Good catch. Fixed it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
