jrgemignani commented on code in PR #2302:
URL: https://github.com/apache/age/pull/2302#discussion_r2687918607
##########
src/backend/utils/adt/agtype.c:
##########
@@ -6038,10 +6050,22 @@ Datum age_properties(PG_FUNCTION_ARGS)
errmsg("properties() argument must be a vertex, an
edge or null")));
}
- agtv_result = GET_AGTYPE_VALUE_OBJECT_VALUE(agtv_object, "properties");
+ /*
+ * Direct field access optimization: properties is at index 2 for vertex
+ * (id=0, label=1, properties=2) and index 4 for edge (id=0, label=1,
+ * end_id=2, start_id=3, properties=4) due to key length sorting.
+ */
+ if (agtv_object->type == AGTV_VERTEX)
+ {
+ agtv_result = AGTYPE_VERTEX_GET_PROPERTIES(agtv_object);
+ }
+ else
+ {
Review Comment:
See previous comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
