gregfelice commented on PR #2341: URL: https://github.com/apache/age/pull/2341#issuecomment-3986674193
Addressed the Copilot suggestions: 1. **DRY false-where construction** — Factored the duplicated `WHERE true = false` construction into `make_false_where_clause()` helper, used by both the early check in `transform_cypher_match()` and the deferred check in `transform_cypher_match_pattern()`. 2. **Cache `clause_chain_has_dml`** — Computed once and reused for both `security_barrier` and deferred label validation, avoiding repeated clause chain traversal. 3. **ORDER BY in regression test** — Added `ORDER BY c.name` to the single-CREATE City test for deterministic result ordering. All regression tests pass (`cypher_match`: ok). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
