gregfelice commented on PR #2347: URL: https://github.com/apache/age/pull/2347#issuecomment-4012892984
Addressed the remaining Copilot suggestions: 1. **Added `ON` to `safe_keywords`** — Without this, property keys or labels named `on` (e.g., `n.on`, `MATCH (n:on)`) would fail to parse. All other keywords added as tokens are also listed in `safe_keywords` via the `schema_name` → `reserved_keyword` → `safe_keywords` path. 2. **Chained (non-terminal) MERGE regression tests** — Added two tests exercising the eager-buffering code path (lines 664-750 in `cypher_merge.c`) with ON CREATE SET and ON MATCH SET. First run creates both nodes and fires ON CREATE SET; second run matches both and fires ON MATCH SET. All regression tests pass (`cypher_merge`: ok). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
