gregfelice commented on PR #2360: URL: https://github.com/apache/age/pull/2360#issuecomment-4129860948
Addressed all 3 Copilot suggestions: 1. **Misplaced comment** — Moved "Helper function to create an ExplainStmt node" from above `make_exists_pattern_sublink()` to directly above `make_explain_stmt()` where it belongs. 2. **%expect/%expect-rr documentation** — Added block comment explaining the conflict budget: 7 shift/reduce from path extension vs arithmetic operators on `-`/`<`, 3 reduce/reduce from `expr_var` vs `var_name_opt` on `)`/`}`/`=`. All resolved by GLR forking + `%dprec` annotations. Noted to update counts if grammar rules change. 3. **Misleading test comment** — Changed "Regular expressions still work" to "Regular (non-pattern) expressions still work" to avoid confusion with regex. Regression test passes (`pattern_expression`: ok). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
