Re: [PR] Make age extension usable from shared_preload_libraries [age]

Fri, 19 Jun 2026 09:59:45 -0700 


serdarmumcu commented on PR #2438:
URL: https://github.com/apache/age/pull/2438#issuecomment-4753443458

   > @serdarmumcu A regression test is failing
   > 
   > <img alt="image" width="480" height="82" 
src="https://private-user-images.githubusercontent.com/1505136/609462916-c93417b8-04ad-404c-8c39-54993572f9dc.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODE4ODg1MDYsIm5iZiI6MTc4MTg4ODIwNiwicGF0aCI6Ii8xNTA1MTM2LzYwOTQ2MjkxNi1jOTM0MTdiOC0wNGFkLTQwNGMtOGMzOS01NDk5MzU3MmY5ZGMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MDYxOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjA2MTlUMTY1NjQ2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YzIxNmYwZTU5OTUxMDAxZDI5YjRmZmVkMWUyYWEyYjU2MTJlNTdhZGZiMjZkZTQxOTkwMWY3ZmQ4MzNlYmFlOSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmcmVzcG9uc2UtY29udGVudC10eXBlPWltYWdlJTJGcG5nIn0.olT5xZNBeiy752AXfsevde15IU2C5SFdANKqauUD-OU";>
   > You are running **make installcheck** locally to see these, right?
   > 
   > Also, if you can look at Copilot's suggestions and resolve them, please :)
   
   Hi @jrgemignani , updated commit addresses everything:
   
   Regression test fixed — used DROP SCHEMA IF EXISTS ag_catalog CASCADE with 
suppressed notices to handle leftover objects from prior tests. Also updated 
drop_label expected error messages to match current upstream.
   Copilot suggestions resolved — added InvalidOid handling in cache callback, 
renamed is_age_extension_exist → is_age_extension_exists.
   All 37 regression tests pass on PG18.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to