gregfelice commented on PR #2360:
URL: https://github.com/apache/age/pull/2360#issuecomment-4763367153
@jrgemignani — rebased onto current `master` (`581d236e`) and ready for
re-review. The changes-requested items from your 05-13 review are all in:
- **`-Werror` scope** — kept `-Werror`, downgraded only the two conflict
categories via `-Wno-error=conflicts-{sr,rr}` (`553e9761`). Any other Bison
warning still fails the build.
- **`%expect` budget** — `%expect 7 / %expect-rr 3`, exact-match pins
(`553e9761`).
- **Parse-time microbench** — LALR vs GLR, +0.7% / +0.02%, both well under
the 5% gate.
- **Follow-up coverage** (your 06-01 ask) — list/map literals, function
args, `OPTIONAL MATCH … WHERE`, `EXISTS`+bare-pattern, and the documented
`(a:Label)` degenerate case (`d372551a`).
The rebase was a clean replay (no logic changes; the only overlap, #2437's
Makefile rework, auto-merged cleanly — the `REGRESS` entry and `BISONFLAGS` are
intact). Re-validated cassert PG18 green: **42/42 including
`pattern_expression`**, CI-exact `EXTRA_TESTS="pgvector fuzzystrmatch
pg_trgm"`, no regression diffs.
When you have a moment, could you kick the `action_required` CI and clear
the stale changes-requested? Docs companion `age-website#364` is ready and
gated to merge after this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
