Copilot commented on code in PR #2452:
URL: https://github.com/apache/age/pull/2452#discussion_r3509355607
##########
drivers/nodejs/package.json:
##########
@@ -34,6 +34,7 @@
},
"devDependencies": {
"@types/jest": "^29.5.14",
+ "@types/node": "^20.19.0",
"@types/pg": "^7.14.10",
Review Comment:
Because package-lock.json isn’t committed, this caret range still allows
`@types/node` to float over time (within <21). If the goal is maximum
install/build reproducibility in CI, consider tightening the range (e.g., to
20.19.x) or pinning an exact patch version.
##########
.github/workflows/nodejs-driver.yaml:
##########
@@ -22,9 +22,9 @@ jobs:
run: docker compose up -d
- name: Set up Node
- uses: actions/setup-node@v3
+ uses: actions/setup-node@v4
with:
- node-version: latest
+ node-version: 20
Review Comment:
`node-version: 20` keeps CI on Node 20, but it still floats to whatever the
latest 20.x is at run time. If strict reproducibility is desired, consider
pinning to a specific minor/patch (e.g., 20.19.0) instead of a floating major.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
