gregfelice commented on PR #2457: URL: https://github.com/apache/age/pull/2457#issuecomment-4875261251
Nice — diff is clean and CI's green on the `PG19` branch. Two things before this lands: 1. **Unused `arg` in the DSM init callback** (`age_global_graph.c:1762`, per Copilot). CI passes today, but now that #2398 turns compiler warnings into build failures, a `-Wunused-parameter` / `COPT=-Werror` build could trip on this. Worth marking it unused (e.g. `(void) arg;` or `PG_USED_FOR_ASSERTS_ONLY`) to keep the PG19 branch warning-clean under the stricter flags. 2. **Attribution to #2427.** This is essentially the rebased/cleaned form of @CyberDem0n's PG19 port (#2427) — same callsite adaptations and regress updates. Since that's a month of external-contributor work, could we carry a `Co-authored-by:` trailer for @CyberDem0n (and/or land #2427 first / note it here)? Just so the origin isn't lost when this supersedes it. Otherwise the PG19 API adaptations look right to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
