gregfelice commented on PR #2406: URL: https://github.com/apache/age/pull/2406#issuecomment-4875298765
@MuhammadTahaNaveed The approach here is solid and I'd like to get it in — it's currently blocked only on a rebase plus two small tidy-ups. If you can: 1. **Rebase onto latest `master`** (it's conflicting now, and @jrgemignani asked back on Apr 30) so CI runs green again. 2. **`INT8PASSBYVAL` fix** — the two `single()` `makeConst(INT8OID, …)` calls use `FLOAT8PASSBYVAL` for the byval flag; they should use `INT8PASSBYVAL`. Functionally identical on all supported platforms, but it's the correct macro for an int8 const. 3. **Empty-list comment** — the revised comment still says "all aggregates return NULL on zero rows"; `count(*)` (incl. `count(*) FILTER (…)`) returns `0`, not NULL. The logic is right, just the comment — worth a one-line correction. (The `make_count_star_filter_agg` hardcoded `INT8OID` return is fine to leave as-is.) Once that's done and CI's green, I'll approve. Thanks for working the full three-valued-logic fix rather than just the UNWIND symptom. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
