jrgemignani commented on PR #2466:
URL: https://github.com/apache/age/pull/2466#issuecomment-4898848665
@MuhammadTahaNaveed @gregfelice Opus 4.8 Max 1M review as Copilot can't
handle it.
## PR #2466 sanity check — PG18-specific CI/docker/driver items preserved ✅
**Verdict: PASS.** This is a true merge of master into PG18 that brings in
all of the
1.8.0 code while keeping the PG18 branch's identity fully intact. Verified
directly on
the PR head (`f4798d33`).
### Merge integrity
- True merge commit — 2 parents (`806fa2eb` PG18 + `9fb7df8c` master);
master is fully
contained; 101 commits into `apache:PG18`.
- Clean `COPT=-Werror` build (0 warnings) and **`installcheck`: All 43 tests
passed**
against PostgreSQL 18.3 on this exact commit.
- (Copilot's automated review posted "couldn't review — exceeds 20,000
lines"; expected
for a catch-up merge, not a failure. CI checks are green.)
### PG18-specific items — all preserved
| Area | Result |
|---|---|
| CI branch triggers (all 5 workflows, push + PR) | `branches: [ "PG18" ]` |
| Leaked `[ "master" ]` / `dev_snapshot_master` in CI/drivers | none |
| CI improvements adopted from master (installcheck.yaml) | `ubuntu-24.04`
pin + Bison guard + `fetch-depth: 100` |
| `docker/Dockerfile` and `docker/Dockerfile.dev` base | `FROM postgres:18`
(all stages) |
| Dockerfile COPY install SQL | `age--1.8.0.sql` |
| Driver test image (compose, JDBC, nodejs) | `apache/age:dev_snapshot_PG18`
|
| `age.control` | `default_version = '1.8.0'` |
| `META.json` PostgreSQL prereq | `18.0.0` (correct for PG18) |
| `.github/labeler.yml` | dropped (matches master's #2335 removal) |
The green Build/Regression check is itself confirmation the CI builds and
tests against
PostgreSQL 18 (master's installcheck is PG18-targeted, now carrying the PG18
trigger).
Net: all of master's 1.8.0 code is brought in, and nothing PG18-specific (CI
triggers,
`postgres:18`, `dev_snapshot_PG18`) was overwritten.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
