linhongyu510 commented on PR #2559: URL: https://github.com/apache/age/pull/2559#issuecomment-6401505279
Addressed both review points, verified on PostgreSQL 18.6 (local build + regress): - **Default label edge (blocking):** `is_redundant_edge_type_qual` now returns false for `IS_DEFAULT_LABEL_EDGE(static_label)`, so `_ag_label_edge` predicates are no longer elided. Repro now returns 0 rows on the PR (matching master). Regression case added to `regress/sql/expr.sql`. - **Nested AND (non-blocking):** `simplify_redundant_edge_type_qual` recurses into nested `AND_EXPR` groups, stopping at OR/NOT boundaries, with a `changed` flag to rebuild the outer conjunction. Build compiles cleanly. Note: one recent CI `build` job failed transiently while cloning postgresql.org (`fatal: early EOF` / network disconnect) — not related to this diff; 5 of 6 build variants pass. I lack admin rights to re-run it, so it may need a maintainer re-run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
