This is an automated email from the ASF dual-hosted git repository.

dimuthuupe pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/airavata.git


The following commit(s) were added to refs/heads/develop by this push:
     new 98b7d16  Making the Experiment as cancelled irrespective of the Job 
status.
98b7d16 is described below

commit 98b7d16065f946f32ccfb886ff8190c6a545c434
Author: dimuthu <dimuthu.upeks...@gmail.com>
AuthorDate: Tue Apr 10 15:05:31 2018 -0400

    Making the Experiment as cancelled irrespective of the Job status.
---
 .../apache/airavata/helix/impl/task/cancel/CancelCompletingTask.java | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git 
a/modules/airavata-helix/helix-spectator/src/main/java/org/apache/airavata/helix/impl/task/cancel/CancelCompletingTask.java
 
b/modules/airavata-helix/helix-spectator/src/main/java/org/apache/airavata/helix/impl/task/cancel/CancelCompletingTask.java
index c8c39a7..f43cc3e 100644
--- 
a/modules/airavata-helix/helix-spectator/src/main/java/org/apache/airavata/helix/impl/task/cancel/CancelCompletingTask.java
+++ 
b/modules/airavata-helix/helix-spectator/src/main/java/org/apache/airavata/helix/impl/task/cancel/CancelCompletingTask.java
@@ -25,7 +25,10 @@ public class CancelCompletingTask extends AiravataTask {
             logger.info("Making process as cancelled as the job is already 
being cancelled or not available");
             saveAndPublishProcessStatus(ProcessState.CANCELED);
         } else {
-            logger.info("Not updating process as cancelled as the job is not 
cancelled yet");
+            // TODO: Some schedulers do not send notifications once the job is 
cancelled. It will cause experiment to stay in
+            // cancelling state forever. So we are making the experiment is 
CANCELLED irrespective of the state of the job
+            logger.info("Job is not in the saturated state but updating 
experiment as cancelled");
+            saveAndPublishProcessStatus(ProcessState.CANCELED);
         }
         return onSuccess("Process " + getProcessId() + " successfully 
cancelled");
     }

-- 
To stop receiving notification emails like this one, please contact
dimuthu...@apache.org.

Reply via email to