jmcarp commented on a change in pull request #4368: AIRFLOW-3561 - improve 
queries
URL: https://github.com/apache/incubator-airflow/pull/4368#discussion_r243938746
 
 

 ##########
 File path: airflow/models/__init__.py
 ##########
 @@ -3249,6 +3259,17 @@ def __exit__(self, _type, _value, _tb):
 
     # /Context Manager ----------------------------------------------
 
+    @property
+    def default_view(self):
+        if self._default_view is None:
+            return configuration.conf.get('webserver', 
'dag_default_view').lower()
+        else:
+            return self._default_view
+
+    def get_default_view(self):
+        """This is only there for backward compatible jina2 templates"""
 
 Review comment:
   I think I'm missing something here. Why can't the templates continue using 
the `default_view` property? Also, s/jina2/jinja2/.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to