Fokko commented on a change in pull request #4368: AIRFLOW-3561 - improve
queries
URL: https://github.com/apache/incubator-airflow/pull/4368#discussion_r243971303
##########
File path: airflow/models/__init__.py
##########
@@ -3249,6 +3259,17 @@ def __exit__(self, _type, _value, _tb):
# /Context Manager ----------------------------------------------
+ @property
+ def default_view(self):
Review comment:
This behavior how differs from the `get_default_view` method. Maybe we can
remove the `get_default_view` method completely:
https://stackoverflow.com/questions/49134141/how-do-i-reference-an-object-property-in-a-method-call-in-jinja2
This would reduce the number of methods on the DAG object. Besides that, I
believe that `dag.default_view` should return the same as
`dag.get_default_view()` since the names are so similar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
