[jira] [Commented] (AIRFLOW-3569) Add "Trigger DAG" button in DAG page

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/AIRFLOW-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16729013#comment-16729013
 ] 

ASF GitHub Bot commented on AIRFLOW-3569:
-----------------------------------------

XD-DENG commented on pull request #4373: [AIRFLOW-3569] Add "Trigger DAG" 
button in DAG page
URL: https://github.com/apache/incubator-airflow/pull/4373
 
 
   ### Jira
   
     - https://issues.apache.org/jira/browse/AIRFLOW-3569
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI 
changes:
   
   #### What this PR is addressing?
   Currently, the (manual) Trigger DAG button is only available at the /home 
page.
   
   But I always encounter this situation: when I'm checking the tree view, or 
code, or graph view of a specific DAG, I may want to manually trigger another 
DagRun. I need to go back to the home page, search for that DAG, trigger the 
DagRun, then click it again to check the tree view.
   
   It may be good if we can have the Manual Trigger DAG button in the DAG page 
as well, rather than only in the home page.
   
   #### Others
   1. **This PR only updated `/www_rbac`**. Given deprecating old UI (`/www`) 
is already in the plan (https://github.com/apache/incubator-airflow/pull/4339), 
updating `/www` may add extra re-basing work for 
https://github.com/apache/incubator-airflow/pull/4339. But kindly let me know 
if any committer finds it's still necessary to update `/www`. 
   
   2. After the DagRun is triggered, users will be re-directed back to the 
`Tree-View` tab of the DAG that was triggered.
   
   #### Screenshots
   <img width="1280" alt="screen shot 2018-12-26 at 8 07 16 pm" 
src="https://user-images.githubusercontent.com/11539188/50445475-efaf0c80-0949-11e9-8677-2093dae3af9d.png";>
   
   <img width="1280" alt="screen shot 2018-12-26 at 7 52 30 pm" 
src="https://user-images.githubusercontent.com/11539188/50445388-6b5c8980-0949-11e9-8951-21f036492b4c.png";>
   
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add "Trigger DAG" button in DAG page
> ------------------------------------
>
>                 Key: AIRFLOW-3569
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3569
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: webapp
>    Affects Versions: 1.10.1
>            Reporter: Xiaodong DENG
>            Assignee: Xiaodong DENG
>            Priority: Minor
>
> Currently, the (manual) Trigger DAG button is only available at the /home 
> page.
> But I always encounter this situation: when I'm checking the tree view, or 
> code, or graph view of a specific DAG, I may want to manually trigger another 
> DagRun. I need to go back to the home page, search for that DAG, then click 
> it to check the tree view again.
> It may be good if we can have the Manual Trigger DAG button in the DAG page 
> as well, rather than only in the home page.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)