jmcarp commented on a change in pull request #4353: [AIRFLOW-3480] Add Database
Deploy/Update/Delete operators
URL: https://github.com/apache/incubator-airflow/pull/4353#discussion_r244021035
##########
File path: airflow/contrib/hooks/gcp_spanner_hook.py
##########
@@ -147,15 +149,13 @@ def _apply_to_instance(self, project_id, instance_id,
configuration_name, node_c
:param func: Method of the instance to be called.
:type func: Callable
"""
- client = self.get_client(project_id)
- instance = client.instance(instance_id,
- configuration_name=configuration_name,
- node_count=node_count,
- display_name=display_name)
+ instance = self.get_client(project_id).instance(
Review comment:
I was going to ask for tests of changes to the hook, but I see that we don't
test this hook at all at the moment. Do you have time to add tests in this PR,
or should we add them in a separate PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
