yohei1126 commented on a change in pull request #4371:
[AIRFLOW-2939][AIRFLOW-3568] fix TypeError on GoogleCloudStorageToS3Operator /
S3ToGoogleCloudStorageOperator
URL: https://github.com/apache/incubator-airflow/pull/4371#discussion_r244071926
##########
File path: airflow/contrib/operators/gcs_to_s3.py
##########
@@ -101,7 +101,7 @@ def execute(self, context):
# Google Cloud Storage and not in S3
bucket_name, _ = S3Hook.parse_s3_url(self.dest_s3_key)
existing_files = s3_hook.list_keys(bucket_name)
- files = set(files) - set(existing_files)
+ files = list(set(files) - set(existing_files))
Review comment:
added traceback on the description. According to the traceback model.py
internally uses json.dumps(value).encode but it does not support set since set
is not JSON serializable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
