[
https://issues.apache.org/jira/browse/AIRFLOW-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734777#comment-16734777
]
ASF GitHub Bot commented on AIRFLOW-3626:
-----------------------------------------
shubhparekh commented on pull request #4438: [AIRFLOW-3626] Fixed zipped Dag
trigger
URL: https://github.com/apache/incubator-airflow/pull/4438
Fixed zipped Dag trigger for Web and Api
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
### Code Quality
- [ ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Unable to Trigger Zipped Dags through Api
> -----------------------------------------
>
> Key: AIRFLOW-3626
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3626
> Project: Apache Airflow
> Issue Type: Bug
> Components: DagRun
> Affects Versions: 2.0.0
> Reporter: Shubham Parekh
> Assignee: Shubham Parekh
> Priority: Major
>
> The resolution to issue
> [AIRFLOW-2614|https://issues.apache.org/jira/browse/AIRFLOW-2614] by [commit|
> https://github.com/apache/incubator-airflow/commit/aa17b5baf886f7e23b3a9bcf8fef45759193f1b6]
> breaks Api based triggering of Zipped Dags.
> Following line in
> [airflow/api/common/experimental/trigger_dag.py|https://codecov.io/gh/apache/incubator-airflow/pull/3590/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==]
>
> dagbag = DagBag(dag_folder=dag_model.fileloc)
> causes the break since dag_model.fileloc for a zipped dag is
> path_to_zip/dagfile.py
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
