[
https://issues.apache.org/jira/browse/AIRFLOW-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736031#comment-16736031
]
ASF GitHub Bot commented on AIRFLOW-3519:
-----------------------------------------
feluelle commented on pull request #4455: [AIRFLOW-3519] Fix example http
operator
URL: https://github.com/apache/airflow/pull/4455
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-3519
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
This PR fixes the sensor in the example http operator that searches for a
string in a byte-like object called response.content.
Now it searches in the decoded response object called response.text.
**NOTE:** This PR also fixes issue
https://issues.apache.org/jira/browse/AIRFLOW-450. This ticket was already
marked as resolved but it actually wasn't.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> example_http_operator is failing due to
> ----------------------------------------
>
> Key: AIRFLOW-3519
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3519
> Project: Apache Airflow
> Issue Type: Bug
> Environment: Windows 10 professional edition.Apache airflow
> Reporter: Arunachalam Ambikapathi
> Assignee: Felix Uellendall
> Priority: Minor
>
> When example_http_operator DAG is called from command line,
> ./airflow trigger_dag example_http_operator
> it was throwing error
> [2018-12-13 10:37:41,892]
> {logging_mixin.py:95}
> INFO - [2018-12-13 10:37:41,892]
> {http_hook.py:126}
> INFO - Sending 'GET' to url: [https://www.google.com/]
> [2018-12-13 10:37:41,992]
> {logging_mixin.py:95}
> WARNING -
> /home/arun1/.local/lib/python3.5/site-packages/urllib3/connectionpool.py:847:
> InsecureRequestWarning: Unverified HTTPS request is being made. Adding
> certificate verification is strongly advised. See:
> [https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings]
> InsecureRequestWarning)
> [2018-12-13 10:37:42,064]
> {models.py:1760}
> *ERROR - a bytes-like object is required, not 'str'*
> This may be due to this was not tested in python3.5 version.
> *Fix:*
> I changed the dag to this and tested it is working.
> from
> response_check=lambda response: True if "Google" in response.content else
> False,
> to
> response_check=lambda response: True if *b'Google'* in response.content else
> False,
> Please apply this in the example it would help new users a lot.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
