XD-DENG commented on a change in pull request #4457: [AIRFLOW-XXX] Fix
TestTriggerDag flaky test
URL: https://github.com/apache/airflow/pull/4457#discussion_r245869601
##########
File path: tests/www_rbac/test_views.py
##########
@@ -1464,12 +1464,9 @@ def test_trigger_dag_button_normal_exist(self):
def test_trigger_dag_button(self):
- test_dag_id = "example_bash_operator"
+ test_dag_id = "example_python_operator"
DR = models.DagRun
- self.session.query(DR).delete()
- self.session.commit()
-
self.client.get('trigger?dag_id={}'.format(test_dag_id))
Review comment:
Hi @feng-tao , may be good to change this line to
```python
self.client.get('/trigger?dag_id={}'.format(test_dag_id))
```
(add the slash), even though seems it's not affecting that much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
