tkaymak edited a comment on issue #4466: [AIRFLOW-3657] Specify zdesk package 
version in setup.py
URL: https://github.com/apache/airflow/pull/4466#issuecomment-452687930
 
 
   @ron819 Compare this line:
   
https://github.com/fprimex/zdesk/blob/a993f1f45f354d9b06dcf8b1e91fcee7ddd2a07c/zdesk/zdesk.py#L91
   to this line:
   
https://github.com/fprimex/zdesk/blob/ed142f56117209c1bb9e1a68cd118e1b9f2228de/zdesk/zdesk.py#L91
   You can see that the signature of the `__init__` changed, now the 3rd 
argument is no longer the boolean for saying that you are identifying with a 
token (`zdesk_token`), which is set to True by default by the hook here in this 
line: 
   
https://github.com/apache/airflow/blob/0222a36ab1109a87e9184c8835a0c75bd2ca1801/airflow/hooks/zendesk_hook.py#L36
   This breaks the authentication.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to