ron819 commented on issue #4466: [AIRFLOW-3657] Specify zdesk package version 
in setup.py
URL: https://github.com/apache/airflow/pull/4466#issuecomment-452706292
 
 
   Actually most of Airflow packages do not pin max versions but min versions.
   To name a few:
   ```
   jdbc = ['jaydebeapi>=1.1.1']
   mssql = ['pymssql>=2.1.1']
   mysql = ['mysqlclient>=1.3.6']
   oracle = ['cx_Oracle>=5.1.2']
   ```
   If the hooks code was with parameters names in the first place the issue you 
are facing now would have been avoided so I think it's a better solution. In 
general I'm against pinning versions unless it's absolutely necessary. However 
best to wait for committers to respond before submitting any further change.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to