[
https://issues.apache.org/jira/browse/AIRFLOW-3680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16740392#comment-16740392
]
ASF GitHub Bot commented on AIRFLOW-3680:
-----------------------------------------
potiuk commented on pull request #4485: [AIRFLOW-3680] Consistency update in
tests for All GCP-related operators
URL: https://github.com/apache/airflow/pull/4485
This commit performs consistency change for tests for all GCP-related
operators.
The operators were evolving over time and the approach to implement those
have changed over time. After some 30+ operators implemented, it's time
to introduce some consistency across all the operators. Those are:
* Separating out System test cases from Unit test cases
* Consistent names of variables that are used in system test cases
* Updated documentation to be consistent across the operators
* Updated examples to be better readable and runnable as System Tests
* Added helper methods that allow to make setUp/tearDown for System Tests
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
### Code Quality
- [ ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Test naming/structure inconsistencies in GCP operators
> ------------------------------------------------------
>
> Key: AIRFLOW-3680
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3680
> Project: Apache Airflow
> Issue Type: Improvement
> Reporter: Jarek Potiuk
> Assignee: Jarek Potiuk
> Priority: Major
>
> The GCP-related operators were evolving over time and the approach to
> implement those
> have changed over time. After some 30+ operators implemented, it's time
> to introduce some consistency across all the operators. Not changing the
> logic of the operators - but rather make sure tests for them use consistent
> naming and can be run in the same way - including Unit tests and System tests
> talking to real GCP project/services.
> Those are:
> * Separating out System test cases from Unit test cases
> * Consistent names of variables that are used in system test cases
> * Updated documentation to be consistent across the operators
> * Updated examples to be better readable and runnable as System Tests
> * Added helper methods that allow to make setUp/tearDown for System Tests
> The test impacted are for the following operators:
> * Bigtable
> * Compute
> * ComputeIgm
> * Function
> * Spanner
> * CloudSql
> * CloudSqlQuery
> * S3ToGcs
> * BigQuery
> * Container
> * Dataproc
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
