drewsonne commented on a change in pull request #4412: [AIRFLOW-3605] Load 
plugins from entry_points
URL: https://github.com/apache/airflow/pull/4412#discussion_r247328697
 
 

 ##########
 File path: tests/plugins/test_plugins_manager_www.py
 ##########
 @@ -83,3 +85,66 @@ def test_menu_links(self):
         [menu_link] = [ml for ml in category.get_children()
                        if isinstance(ml, MenuLink)]
         self.assertEqual('Test Menu Link', menu_link.name)
+
+
+class MockPluginA(AirflowPlugin):
+    name = 'plugin-a'
+
+
+class MockPluginB(AirflowPlugin):
+    name = 'plugin-b'
+
+
+class MockPluginC(AirflowPlugin):
+    name = 'plugin-c'
+
+
+class PluginsTestEntrypointLoad(unittest.TestCase):
 
 Review comment:
   From what I've seen so far, the plugin manager loads the plugins, and dumps 
their respective components (hooks, operators, blueprints, etc) into lists and 
then it's up to other components to decide which lists to reference.
   
   I'm happy to put in another PR to move it so keep thing Clean™, but I'm not 
sure where it'd go. Are there plans for the old UI to be deprecated at a time 
in the future? That could solve the problem.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to