[
https://issues.apache.org/jira/browse/AIRFLOW-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742014#comment-16742014
]
ASF subversion and git services commented on AIRFLOW-3689:
----------------------------------------------------------
Commit dde72e2553551ddd0f1f94fa83058208be192244 in airflow's branch
refs/heads/dont-bake-env-into-tmp-config from Xiaodong
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=dde72e2 ]
[AIRFLOW-3689] Update pop-up message when deleting DAG in RBAC UI (#4505)
This feature was added in https://github.com/apache/airflow/pull/4287,
but the pop-up messages was only updated in
airflow/www/templates/airflow/dag.html,
while it should be updated for all dag.html & dags.html for both /www and
/www_rbac.
> Update pop-up messages for feature "Keeps records in Log Table when delete
> DAG"
> -------------------------------------------------------------------------------
>
> Key: AIRFLOW-3689
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3689
> Project: Apache Airflow
> Issue Type: Improvement
> Components: api
> Reporter: Xiaodong DENG
> Assignee: Xiaodong DENG
> Priority: Minor
> Fix For: 1.10.2
>
>
> In PR [https://github.com/apache/airflow/pull/4287,] I developed the feature
> "keeps records in Log Table when delete DAG". The pop-up message that appear
> when user tries to delete a DAG should also be updated, in order to remind
> users that records in "log" table will not be removed.
> This should be updated in
> -
> [airflow/www/templates/airflow/dag.html|https://github.com/apache/airflow/pull/4287/files#diff-9f17202cd46d5c42ef03c2406ba80fd9]
> -
> [airflow/www/templates/airflow/dags.html|https://github.com/apache/airflow/pull/4287/files#diff-9f17202cd46d5c42ef03c2406ba80fd9]
> -
> [airflow/www_rbac/templates/airflow/dag.html|https://github.com/apache/airflow/pull/4287/files#diff-9f17202cd46d5c42ef03c2406ba80fd9]
> -
> [airflow/www_rbac/templates/airflow/dags.html|https://github.com/apache/airflow/pull/4287/files#diff-9f17202cd46d5c42ef03c2406ba80fd9]
>
> But only the first one was updated. This should be followed up.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
