potiuk commented on issue #4500: [AIRFLOW-3681] All GCP operators have now 
optional GCP Project ID
URL: https://github.com/apache/airflow/pull/4500#issuecomment-454184266
 
 
   All is done now @kaxil : This is a monster change, but it's mostly in tests. 
The change includes changing the project_id to be keyword based and Added 
150+(!) new unit test cases for all hooks in GCP.
   
   I also corrected all places where the hooks were returning True if 
successful and raising Exception if there was a problem. It was mentioned 
before and we agreed it made little sense - now the hooks return Nothing.
   
   I also passed it through automated system tests with real GCP project and 
the tests are all green :). 
   
   Here is the result of our automated build for System tests and relevant unit 
test cases.
   
   
https://storage.googleapis.com/polidea-airflow-builds/4846b9c3-8b0d-418f-b302-52980928b284/index.html
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to